Enable keyboard accelerators while a menu is open

ash/accelerators/accelerator_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_ACCELERATORS_ACCELERATOR_CONTROLLER_H_
 #define ASH_ACCELERATORS_ACCELERATOR_CONTROLLER_H_
 
 #include <map>
 #include <set>
 
@@ skipping 95 matching lines @@
   }
   ScreenshotDelegate* screenshot_delegate() {
     return screenshot_delegate_.get();
   }
 
   // Provides access to the ExitWarningHandler for testing.
   ExitWarningHandler* GetExitWarningHandlerForTest() {
     return &exit_warning_handler_;
   }
 
+  // Checks if the given accelerator can be performed without the need to close
+  // the menu (if one is present), returns true if this is the case, and false
+  // otherwise (the menu should be closed and the accelerator should continue
+  // its normal propagation).
+  bool ShouldMenuBeKeptOpenForAccelerator(

[pkotwicz, 2015/08/26 01:26:54]

I think that it would be clearer if this method was named
ShouldCloseMenuAndRepostAccelerator(). The return value would have to be the
opposite of what it is now.
I think that ShouldMenuBeKeptOpenForAccelerator() returning true for
accelerators which are never handled by AcceleratorController is confusing.

[afakhry, 2015/08/26 18:39:21]

Done.

+      const ui::Accelerator& accelerator) const;
+
   ui::AcceleratorHistory* accelerator_history() {
     return accelerator_history_.get();
   }
 
   // Overridden from ui::AcceleratorTarget:
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
   bool CanHandleAccelerators() const override;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(AcceleratorControllerTest, GlobalAccelerators);
@@ skipping 59 matching lines @@
   // Preferred actions. See accelerator_table.h for details.
   std::set<int> preferred_actions_;
   // Reserved actions. See accelerator_table.h for details.
   std::set<int> reserved_actions_;
   // Actions which will not be repeated while holding the accelerator key.
   std::set<int> nonrepeatable_actions_;
   // Actions allowed in app mode.
   std::set<int> actions_allowed_in_app_mode_;
   // Actions disallowed if there are no windows.
   std::set<int> actions_needing_window_;
+  // Actions that can be performed without closing the menu (if one is present).
+  std::set<int> actions_keeping_menu_open_;
 
   DISALLOW_COPY_AND_ASSIGN(AcceleratorController);
 };
 
 }  // namespace ash
 
 #endif  // ASH_ACCELERATORS_ACCELERATOR_CONTROLLER_H_