Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1138523004: pkg/analysis_server: don't explicitly import matcher - use exports from unittest (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

pkg/analysis_server: don't explicitly import matcher - use exports from unittest This will avoid breaks when the test package is checked in Also remove exec bit from root files R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, --3 lines) Patch
A pkg/analysis_server/AUTHORS View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/analysis_server/CHANGELOG.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/analysis_server/CONTRIBUTING.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/analysis_server/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kevmoo
5 years, 7 months ago (2015-05-08 20:46:45 UTC) #2
kevmoo
5 years, 7 months ago (2015-05-08 20:54:00 UTC) #4
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-08 20:55:27 UTC) #5
kevmoo
Committed patchset #1 (id:1) manually as 45657 (presubmit successful).
5 years, 7 months ago (2015-05-08 20:57:56 UTC) #6
pquitslund
5 years, 7 months ago (2015-05-08 20:58:27 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698