Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1138523003: [memory-inspector] Fix zygote wrapper script and UI scrolling (Closed)

Created:
5 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-inspector] Fix zygote wrapper script and UI scrolling This is a minor fix to the Zygote wrapper script (for full profiles). Furthermore, this adds a workaround to a recent regression of the Google Data Table UI (https://goo.gl/TXr3vL) which was causing the Memory Inspector UI to forget its scroll position every couple of seconds. BUG= Committed: https://crrev.com/2145acc91dac99cab968da991002874d57848a97 Cr-Commit-Position: refs/heads/master@{#329666}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M tools/memory_inspector/memory_inspector/backends/android_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/processes.js View 3 chunks +7 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/rootUi.js View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Primiano Tucci (use gerrit)
Small fixes, PTAL
5 years, 7 months ago (2015-05-13 09:09:27 UTC) #3
petrcermak
LGTM even though, strictly speaking, these should be two separate patches :-) Thanks, Petr
5 years, 7 months ago (2015-05-13 09:41:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138523003/20001
5 years, 7 months ago (2015-05-13 17:12:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-13 17:35:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:36:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2145acc91dac99cab968da991002874d57848a97
Cr-Commit-Position: refs/heads/master@{#329666}

Powered by Google App Engine
This is Rietveld 408576698