Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1138503005: Fix examples for File System Provider API. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix examples for File System Provider API. TEST=Manually tested both. BUG=481670 Committed: https://crrev.com/78d56d546470d8f50ecd13d0bc1d2d82d95d9996 Cr-Commit-Position: refs/heads/master@{#330461}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing callbacks. #

Messages

Total messages: 9 (3 generated)
mtomasz
@kalman: PTAL. Thanks.
5 years, 7 months ago (2015-05-18 08:27:39 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/1138503005/diff/1/chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js File chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js (right): https://codereview.chromium.org/1138503005/diff/1/chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js#newcode111 chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js:111: }); do you want to call onSuccess anywhere ...
5 years, 7 months ago (2015-05-18 20:00:54 UTC) #3
mtomasz
https://codereview.chromium.org/1138503005/diff/1/chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js File chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js (right): https://codereview.chromium.org/1138503005/diff/1/chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js#newcode111 chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/background.js:111: }); On 2015/05/18 20:00:54, kalman wrote: > do you ...
5 years, 7 months ago (2015-05-19 00:42:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138503005/20001
5 years, 7 months ago (2015-05-19 00:43:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 00:50:52 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:51:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78d56d546470d8f50ecd13d0bc1d2d82d95d9996
Cr-Commit-Position: refs/heads/master@{#330461}

Powered by Google App Engine
This is Rietveld 408576698