components/cronet/android/test/quic_test_server.cc - Issue 1138493002: [Cronet] Added a unit test in QuicTest to test async API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/quic_test_server.cc

Issue 1138493002: [Cronet] Added a unit test in QuicTest to test async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java ('k') | components/cronet/android/test/src/org/chromium/net/CronetTestActivity.java » ('j') | components/cronet/android/test/src/org/chromium/net/CronetTestActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/quic_test_server.cc

diff --git a/components/cronet/android/test/quic_test_server.cc b/components/cronet/android/test/quic_test_server.cc

index f4b14f964f13617503ca3c640e0c9825bab6011c..74c73ae59f692c65257c1bdc58b46e81bdfd5ae1 100644

--- a/components/cronet/android/test/quic_test_server.cc

+++ b/components/cronet/android/test/quic_test_server.cc

@@ -8,6 +8,7 @@

#include "base/android/jni_string.h"

#include "base/bind.h"

#include "base/files/file_path.h"

+#include "base/files/file_util.h"

#include "base/threading/thread.h"

#include "jni/QuicTestServer_jni.h"

#include "net/base/ip_endpoint.h"

@@ -30,6 +31,8 @@ void ServeFilesFromDirectory(

DCHECK(g_quic_server_thread->task_runner()->BelongsToCurrentThread());

DCHECK(!g_quic_server);

base::FilePath file_dir = directory.Append("quic_data");

+ bool file_exist = base::PathExists(file_dir);

+ CHECK(file_exist) << "Quic data does not exist";

mef 2015/05/13 17:00:03 Do we need |file_exist| variable?

xunjieli 2015/05/13 17:06:16 Done. I don't think we do.

net::tools::QuicInMemoryCache::GetInstance()->InitializeFromDirectory(

file_dir.value());

net::IPAddressNumber ip;