Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1138493002: [Cronet] Added a unit test in QuicTest to test async API. (Closed)

Created:
5 years, 7 months ago by xunjieli
Modified:
5 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Added a unit test in QuicTest to test async API. This CL removed the incorrect comment in QuicTest, and added a second unit test to make sure addQuicHints works for the new async API. It made QuicTestServer install test files during start up to match the new behavior of NativeTestServer, and adds an assertion to make sure the server has test data. The CL caches the result returned by CronetTestActivity#getContextConfig, so we don't need to go through that path for initializing mUrlRequestContext, mHttpUrlRequestFactory and mStreamHandlerFactory, and cleaned up log statements. Committed: https://crrev.com/f49eca0d374314831d2d74ca1bab1b7158ee8816 Cr-Commit-Position: refs/heads/master@{#329678}

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -44 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 2 chunks +41 lines, -25 lines 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/CronetTestActivity.java View 8 chunks +42 lines, -19 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/QuicTestServer.java View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xunjieli
Hi Misha, I realize that in addition to the incorrect comment that I made in ...
5 years, 7 months ago (2015-05-08 15:53:57 UTC) #3
xunjieli
Ping. Misha, my Sdch CL depends on this one. Could you take a look when ...
5 years, 7 months ago (2015-05-13 16:41:19 UTC) #4
mef
lgtm https://codereview.chromium.org/1138493002/diff/20001/components/cronet/android/test/quic_test_server.cc File components/cronet/android/test/quic_test_server.cc (right): https://codereview.chromium.org/1138493002/diff/20001/components/cronet/android/test/quic_test_server.cc#newcode35 components/cronet/android/test/quic_test_server.cc:35: CHECK(file_exist) << "Quic data does not exist"; Do ...
5 years, 7 months ago (2015-05-13 17:00:03 UTC) #5
xunjieli
Thanks for reviewing this on a short notice! https://codereview.chromium.org/1138493002/diff/20001/components/cronet/android/test/quic_test_server.cc File components/cronet/android/test/quic_test_server.cc (right): https://codereview.chromium.org/1138493002/diff/20001/components/cronet/android/test/quic_test_server.cc#newcode35 components/cronet/android/test/quic_test_server.cc:35: CHECK(file_exist) ...
5 years, 7 months ago (2015-05-13 17:06:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138493002/40001
5 years, 7 months ago (2015-05-13 17:07:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-13 18:20:50 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:21:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f49eca0d374314831d2d74ca1bab1b7158ee8816
Cr-Commit-Position: refs/heads/master@{#329678}

Powered by Google App Engine
This is Rietveld 408576698