src/ic/ic.cc - Issue 1138483005: Reland "Mark internal AccessorInfo properties as 'special data properties'"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1138483005: Reland "Mark internal AccessorInfo properties as 'special data properties'" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 387c1cfc567495f0e731301e63e5800a67cdb70e..b275394be89192113a7b89de87a51af8c41f6ccd 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1664,7 +1664,9 @@ Handle<Code> StoreIC::CompileHandler(LookupIterator* lookup,

break;

}

Handle<Object> accessors = lookup->GetAccessors();

- if (accessors->IsExecutableAccessorInfo()) {

+ if (accessors->IsExecutableAccessorInfo() &&

+ (!AccessorInfo::cast(*accessors)->is_special_data_property() ||

Igor Sheludko 2015/05/18 11:53:15 Maybe it's better to handle special data property

+ lookup->HolderIsReceiverOrHiddenPrototype())) {

Handle<ExecutableAccessorInfo> info =

Handle<ExecutableAccessorInfo>::cast(accessors);

if (v8::ToCData<Address>(info->setter()) == 0) {

« no previous file with comments | « src/accessors.cc ('k') | src/lookup.cc » ('j') | no next file with comments »