Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/mime_sniffer.cc

Issue 1138483004: Remove TODO for mime-sniffing of mpeg types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes and remove TODO. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mime_sniffer.cc
diff --git a/net/base/mime_sniffer.cc b/net/base/mime_sniffer.cc
index 45e810f2b1a2c86fb4eabe78e5bd3e318044233a..6929e53660e0054fa9c78e1834c99a33acee2b7e 100644
--- a/net/base/mime_sniffer.cc
+++ b/net/base/mime_sniffer.cc
@@ -162,10 +162,6 @@ static const MagicNumber kMagicNumbers[] = {
MAGIC_NUMBER("audio/mpeg", "ID3")
MAGIC_NUMBER("image/webp", "RIFF....WEBPVP8 ")
MAGIC_NUMBER("video/webm", "\x1A\x45\xDF\xA3")
- // TODO(abarth): we don't handle partial byte matches yet
- // MAGIC_NUMBER("video/mpeg", "\x00\x00\x01\xB")
- // MAGIC_NUMBER("audio/mpeg", "\xFF\xE")
- // MAGIC_NUMBER("audio/mpeg", "\xFF\xF")
MAGIC_NUMBER("application/zip", "PK\x03\x04")
MAGIC_NUMBER("application/x-rar-compressed", "Rar!\x1A\x07\x00")
MAGIC_NUMBER("application/x-msmetafile", "\xD7\xCD\xC6\x9A")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698