Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 1138473002: qcms: Limit vcgt table to a maximum of 1024 entries (Closed)

Created:
5 years, 7 months ago by robert.bradford
Modified:
5 years, 7 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

qcms: Limit vcgt table to a maximum of 1024 entries This is a reasonable limit on the size of the vcgt to permit; this will prevent rogue data potentially causing an OOM situation. TEST=With test file blue-vcgt-test-color-profile-1024.icc observe that the vcgt data is parsed and made available through the API but with blue-vcgt-test-color-profile-2048.icc the vcgt is ignored. R=noel@chromium.org BUG=471749 Committed: https://crrev.com/4cc1320a9ba15971f5d67f704b5e732d61ba2cdd Cr-Commit-Position: refs/heads/master@{#328966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M third_party/qcms/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/google.patch View 18 chunks +21 lines, -17 lines 0 comments Download
M third_party/qcms/src/iccread.c View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
robert.bradford
5 years, 7 months ago (2015-05-08 14:01:31 UTC) #1
Noel Gordon
LGTM
5 years, 7 months ago (2015-05-08 14:37:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138473002/1
5 years, 7 months ago (2015-05-08 14:39:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 16:38:20 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 16:39:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cc1320a9ba15971f5d67f704b5e732d61ba2cdd
Cr-Commit-Position: refs/heads/master@{#328966}

Powered by Google App Engine
This is Rietveld 408576698