Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1138463003: A GL Query cache of 1024 items is enough (was 4096). (Closed)

Created:
5 years, 7 months ago by Daniel Bratell
Modified:
5 years, 7 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A GL Query cache of 1024 items is enough (was 4096). Since each QuerySyncManager has its own cache, even a moderate cache size expands to several hundred KB of memory usage. This makes it slightly smaller to save some of that memory. It is believed to be unlikely that the cache has to be big anyway. In ad-hoc testing I've only seen 20 queries in total (unclear how many of them were in parallel). (This is alt #1 in bug 485536) BUG=485536 R=reveman@chromium.org Committed: https://crrev.com/a5989e1f8931cf00016b5e53a088df6ab6a1f3a1 Cr-Commit-Position: refs/heads/master@{#329383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/command_buffer/client/query_tracker.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Daniel Bratell
5 years, 7 months ago (2015-05-08 13:36:00 UTC) #1
reveman
lgtm
5 years, 7 months ago (2015-05-08 13:40:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138463003/1
5 years, 7 months ago (2015-05-11 10:00:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62564)
5 years, 7 months ago (2015-05-11 10:07:57 UTC) #6
Daniel Bratell
I need one more review here. piman, could you take a look please?
5 years, 7 months ago (2015-05-11 14:09:25 UTC) #8
piman
lgtm
5 years, 7 months ago (2015-05-11 20:57:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138463003/1
5 years, 7 months ago (2015-05-12 08:50:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 09:45:47 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 09:46:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5989e1f8931cf00016b5e53a088df6ab6a1f3a1
Cr-Commit-Position: refs/heads/master@{#329383}

Powered by Google App Engine
This is Rietveld 408576698