Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1138443004: Fix crash in network_service. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in network_service. The problem is that |response| was passed in the Bind call before the body was taken out. I saw this because of null dereference on Windows. The order of evaluation is undefined, which is why it worked on Linux. Committed: https://crrev.com/05f187772cffebd3caed3936e314c7ce92ba716b Cr-Commit-Position: refs/heads/master@{#330634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/services/network/http_connection_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 7 months ago (2015-05-19 20:52:10 UTC) #2
yzshen1
On 2015/05/19 20:52:10, jam wrote: Ah, evaluation order of arguments! :/ Nice catch. Thanks! LGTM
5 years, 7 months ago (2015-05-19 20:57:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138443004/1
5 years, 7 months ago (2015-05-19 22:11:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 22:24:00 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:25:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05f187772cffebd3caed3936e314c7ce92ba716b
Cr-Commit-Position: refs/heads/master@{#330634}

Powered by Google App Engine
This is Rietveld 408576698