Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1138423002: Enable file_system_provider::Service in incognito. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable file_system_provider::Service in incognito. There is no need to limit the FSP API to non-incognito only. Especially, such limitation was causing crashes in Files app running in incognito, which assumed the service exists, but it didn't. With this CL the service is created for both non-incognito and incognito pages. Both instances are *same*, so mounted providers will be shared between incognito and non-incognito windows. TEST=Tested manually by launching with --incognito BUG=487901 Committed: https://crrev.com/5c23b37e51dba88729571ad01360c7ffc40737d5 Cr-Commit-Position: refs/heads/master@{#329792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/chromeos/file_system_provider/service_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_factory.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 7 months ago (2015-05-14 02:02:24 UTC) #3
hirono
lgtm
5 years, 7 months ago (2015-05-14 03:29:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138423002/1
5 years, 7 months ago (2015-05-14 03:30:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 03:33:58 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 03:34:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c23b37e51dba88729571ad01360c7ffc40737d5
Cr-Commit-Position: refs/heads/master@{#329792}

Powered by Google App Engine
This is Rietveld 408576698