Support the full-screen state when showing a chrome window

Support the full-screen state when showing a chrome window

The SHOW_STATE_FULLSCREEN state has not been supported in Windows
so this CL implements it and allows browser_tests to pass the
test for creating a full screen extension window without manually
calling setFullscreenMode().

BUG=473228
Committed: https://crrev.com/051aece17c0e035938cdd99233967f1cba865b4a
Cr-Commit-Position: refs/heads/master@{#330602}

[joone, 2015-05-14 23:29:56]

joone.hur@intel.com changed reviewers:
+ erg@chromium.org, sadrul@chromium.org

[joone, 2015-05-14 23:29:57]

Please take a look at this CL.

[sadrul, 2015-05-15 00:45:08]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org
- erg@chromium.org, sadrul@chromium.org

[sadrul, 2015-05-15 00:45:09]

--> sky@ for Windows change.

[sky, 2015-05-18 17:12:36]

Test coverage?

[joone, 2015-05-19 01:19:53]

On 2015/05/18 17:12:36, sky wrote:
> Test coverage?

There is a test case for creating a full screen chrome window.
My CL allows browser_tests to pass the test without manually calling
setFullscreenMode().

[sky, 2015-05-19 04:20:04]

https://codereview.chromium.org/1138383008/diff/20001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/1138383008/diff/20001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:574: SetFullscreen(true);
I'm a bit nervous about invoking this before the window is actually showing.

[joone, 2015-05-19 17:40:49]

https://codereview.chromium.org/1138383008/diff/20001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/1138383008/diff/20001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:574: SetFullscreen(true);
On 2015/05/19 04:20:04, sky wrote:
> I'm a bit nervous about invoking this before the window is actually showing.

When SetFullscreen is called after ShowWindow, we can see the transition from
windowed(black) to full screen.

[sky, 2015-05-19 19:49:52]

Got it, LGTM

[joone, 2015-05-19 19:50:57]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2015-05-19 19:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138383008/20001

[commit-bot: I haz the power, 2015-05-19 20:51:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 20:53:17]

Patchset 2 (id:??) landed as
https://crrev.com/051aece17c0e035938cdd99233967f1cba865b4a
Cr-Commit-Position: refs/heads/master@{#330602}