Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1138383003: Prefer jinja2 from third_party over system library in process_resources.py (Closed)

Created:
5 years, 7 months ago by gordanac
Modified:
5 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefer jinja2 from third_party over system library in process_resources.py Make sure jinja2 from third_party is used. Committed: https://crrev.com/f42e3c492343f9121df5ea85fb15bfa7d2f2fdcb Cr-Commit-Position: refs/heads/master@{#330341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/gyp/process_resources.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
gordanac
Please take a look. Initial change is: https://codereview.chromium.org/1136653002
5 years, 7 months ago (2015-05-14 15:41:30 UTC) #2
cjhopman
lgtm
5 years, 7 months ago (2015-05-15 20:00:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138383003/1
5 years, 7 months ago (2015-05-18 08:40:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 09:49:24 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:34:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f42e3c492343f9121df5ea85fb15bfa7d2f2fdcb
Cr-Commit-Position: refs/heads/master@{#330341}

Powered by Google App Engine
This is Rietveld 408576698