Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Issue 1138373002: Autofill: Fix WalletIntegrationAvailable() regression. (Closed)

Created:
5 years, 7 months ago by bondd
Modified:
5 years, 7 months ago
Reviewers:
*Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pay_07_check_wallet_available_03
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Fix WalletIntegrationAvailable() regression. Accidentally inverted a check during refactoring in https://crrev.com/1137513002 Add back the '!' character that I deleted, and add unit tests to guard against future regressions. BUG=486675 Committed: https://crrev.com/93d1d2484b1637bb7a69eade2cdd398b216bdc69 Cr-Commit-Position: refs/heads/master@{#329933}

Patch Set 1 #

Patch Set 2 : Add missing dep for GN build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -1 line) Patch
M components/autofill/core/browser/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/options_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/autofill/core/browser/options_util_unittest.cc View 1 chunk +199 lines, -0 lines 0 comments Download
M components/autofill/core/browser/test_personal_data_manager.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/autofill/core/browser/test_personal_data_manager.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bondd
5 years, 7 months ago (2015-05-13 01:32:01 UTC) #3
Evan Stade
wow these are some thorough tests! lgtm
5 years, 7 months ago (2015-05-13 21:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138373002/1
5 years, 7 months ago (2015-05-13 21:54:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/37397)
5 years, 7 months ago (2015-05-13 22:24:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138373002/20001
5 years, 7 months ago (2015-05-14 20:28:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 21:21:42 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 21:22:17 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93d1d2484b1637bb7a69eade2cdd398b216bdc69
Cr-Commit-Position: refs/heads/master@{#329933}

Powered by Google App Engine
This is Rietveld 408576698