Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138363004: Navigate to a locally hosted webpage instead of google.com (Closed)

Created:
5 years, 7 months ago by Changwan Ryu
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Navigate to a locally hosted webpage instead of google.com BUG=487364 Committed: https://crrev.com/b10c773c8e814f62bbbee96803ba983567b0a637 Cr-Commit-Position: refs/heads/master@{#329795}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : added directory to isolate file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/chrome_shell_test_apk.isolate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/android/url_overriding/navigation_with_fallback_url.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Changwan Ryu
5 years, 7 months ago (2015-05-13 07:33:45 UTC) #2
jbudorick
lgtm w/ nit This is awesome! https://codereview.chromium.org/1138363004/diff/20001/chrome/test/data/android/url_overriding/navigation_with_fallback_url.html File chrome/test/data/android/url_overriding/navigation_with_fallback_url.html (right): https://codereview.chromium.org/1138363004/diff/20001/chrome/test/data/android/url_overriding/navigation_with_fallback_url.html#newcode15 chrome/test/data/android/url_overriding/navigation_with_fallback_url.html:15: location.href = 'intent://test/#Intent;scheme=test;package=com.chrome.test;S.browser_fallback_url=http%3A%2F%2Flocalhost%3A8000%2Fchrome%2Ftest%2Fdata%2Fandroid%2Furl_overriding%2Fhello.html;end'; ...
5 years, 7 months ago (2015-05-13 12:59:58 UTC) #3
Maria
lgtm
5 years, 7 months ago (2015-05-13 17:55:48 UTC) #4
Changwan Ryu
https://codereview.chromium.org/1138363004/diff/20001/chrome/test/data/android/url_overriding/navigation_with_fallback_url.html File chrome/test/data/android/url_overriding/navigation_with_fallback_url.html (right): https://codereview.chromium.org/1138363004/diff/20001/chrome/test/data/android/url_overriding/navigation_with_fallback_url.html#newcode15 chrome/test/data/android/url_overriding/navigation_with_fallback_url.html:15: location.href = 'intent://test/#Intent;scheme=test;package=com.chrome.test;S.browser_fallback_url=http%3A%2F%2Flocalhost%3A8000%2Fchrome%2Ftest%2Fdata%2Fandroid%2Furl_overriding%2Fhello.html;end'; On 2015/05/13 12:59:58, jbudorick wrote: > ...
5 years, 7 months ago (2015-05-14 02:18:30 UTC) #5
Changwan Ryu
Adding csharp for isolate change.
5 years, 7 months ago (2015-05-14 02:20:38 UTC) #7
csharp
isolate change lgtm
5 years, 7 months ago (2015-05-14 02:27:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138363004/40001
5 years, 7 months ago (2015-05-14 02:34:23 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-14 03:54:11 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 03:55:05 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b10c773c8e814f62bbbee96803ba983567b0a637
Cr-Commit-Position: refs/heads/master@{#329795}

Powered by Google App Engine
This is Rietveld 408576698