Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1138363002: Remove the 'brillo' wrapper. (Closed)

Created:
5 years, 7 months ago by dgarrett
Modified:
5 years, 6 months ago
Reviewers:
bsimonnet, Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove the 'brillo' wrapper. This command no longer makes sense here, it should only be used from the chromite bootstrap workflow. This is basically a revert of cl:896393003 BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
D brillo View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (10 generated)
dgarrett
Ping?
5 years, 7 months ago (2015-05-18 17:03:46 UTC) #2
bsimonnet
On 2015/05/18 17:03:46, dgarrett wrote: > Ping? lgtm
5 years, 7 months ago (2015-05-18 17:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138363002/1
5 years, 7 months ago (2015-05-18 17:53:04 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-18 17:53:07 UTC) #7
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-18 20:45:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138363002/1
5 years, 7 months ago (2015-05-18 20:46:40 UTC) #10
commit-bot: I haz the power
Presubmit check for 1138363002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-18 20:48:21 UTC) #12
dgarrett
Those failures are not caused by this CL. Retrying to see if it's just flake.
5 years, 7 months ago (2015-05-18 20:52:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138363002/1
5 years, 7 months ago (2015-05-18 20:52:42 UTC) #15
commit-bot: I haz the power
Presubmit check for 1138363002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-18 20:54:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138363002/1
5 years, 7 months ago (2015-05-19 16:04:05 UTC) #19
commit-bot: I haz the power
Presubmit check for 1138363002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-19 16:05:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138363002/1
5 years, 6 months ago (2015-05-26 21:07:40 UTC) #23
commit-bot: I haz the power
5 years, 6 months ago (2015-05-26 21:12:00 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295415

Powered by Google App Engine
This is Rietveld 408576698