Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: components/test/data/password_manager/automated_tests/run_tests.py

Issue 1138353003: [Password manager tests automation] Fixes buzzfeed test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test/data/password_manager/automated_tests/run_tests.py
diff --git a/components/test/data/password_manager/automated_tests/run_tests.py b/components/test/data/password_manager/automated_tests/run_tests.py
index 7a054a5444b1a1a15785f441577243456f65c379..c00a53b3419dcd229c97a295143a21132a9dbd07 100644
--- a/components/test/data/password_manager/automated_tests/run_tests.py
+++ b/components/test/data/password_manager/automated_tests/run_tests.py
@@ -112,14 +112,15 @@ def RunTestCaseOnWebsite((website, test_case, config)):
profile_path = tempfile.mkdtemp()
# The tests can be flaky. This is why we try to rerun up to 3 times.
- attempts = 3
+ attempts = 1
vabr (Chromium) 2015/05/18 16:13:34 Did you mean to revert the changes in this file?
melandory 2015/05/19 08:06:34 Done.
result = ("", "", False, "")
logger = logging.getLogger("run_tests")
for _ in xrange(attempts):
shutil.rmtree(path=profile_path, ignore_errors=True)
logger.log(SCRIPT_DEBUG, "Run of test case %s of website %s started",
test_case, website)
- try:
+ #try:
+ if True:
with stopit.ThreadingTimeout(100) as timeout:
logger.log(SCRIPT_DEBUG,
"Run test with parameters: %s %s %s %s %s %s",
@@ -134,8 +135,8 @@ def RunTestCaseOnWebsite((website, test_case, config)):
_, _, success, _ = result
if success:
return result
- except Exception as e:
- result = (website, test_case, False, e)
+ #except Exception as e:
+ # result = (website, test_case, False, e)
return result

Powered by Google App Engine
This is Rietveld 408576698