Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1138343002: Bump versionCode of SkyDemo.apk to avoid downgrade warning. (Closed)

Created:
5 years, 7 months ago by eseidel
Modified:
5 years, 7 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Bump versionCode of SkyDemo.apk to avoid downgrade warning. Also teach both skydb and shelldb to ignore version downgrades I did not change sky_tool since maybe the warning makes sense there? R=abarth@chromium.org, chinmaygarde@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c0a3ac895a5d6320ce697bba4908d5700bfe0948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M sky/apk/demo/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/shelldb View 1 chunk +2 lines, -1 line 0 comments Download
M sky/tools/skydb View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 7 months ago (2015-05-12 21:32:33 UTC) #1
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-12 22:00:56 UTC) #3
eseidel
5 years, 7 months ago (2015-05-14 00:34:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0a3ac895a5d6320ce697bba4908d5700bfe0948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698