Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1138333003: Sk4px: alphas() and Load[24]Alphas() (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4px: alphas() and Load[24]Alphas() alphas() extracts the 4 alphas from an existing Sk4px as another Sk4px. LoadNAlphas() constructs an Sk4px from N packed alphas. In both cases, we end up with 4x repeated alphas aligned with their pixels. alphas() A0 R0 G0 B0 A1 R1 G1 B1 A2 R2 G2 B2 A3 R3 G3 B3 -> A0 A0 A0 A0 A1 A1 A1 A1 A2 A2 A2 A2 A3 A3 A3 A3 Load4Alphas() A0 A1 A2 A3 -> A0 A0 A0 A0 A1 A1 A1 A1 A2 A2 A2 A2 A3 A3 A3 A3 Load2Alphas() A0 A1 -> A0 A0 A0 A0 A1 A1 A1 A1 0 0 0 0 0 0 0 0 This is a 5-10% speedup for AA on Intel, and wash on ARM. AA is still mostly dominated by the final lerp. alphas() isn't used yet, but it's similar enough to Load[24]Alphas() that it was easier to write all at once. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8a90edc2a58a4f8a4b4da73eb08e943be09538c0

Patch Set 1 #

Patch Set 2 : Splat -> Load4Alphas / Load2Alphas #

Patch Set 3 : Splat -> Load4Alphas / Load2Alphas #

Patch Set 4 : Alpha #

Patch Set 5 : comment #

Patch Set 6 : tidy #

Patch Set 7 : NEON impl #

Patch Set 8 : Already have byte constructor #

Patch Set 9 : _none #

Patch Set 10 : better SSE2 #

Patch Set 11 : neon too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -11 lines) Patch
M src/core/Sk4px.h View 1 2 3 4 5 6 7 3 chunks +15 lines, -11 lines 0 comments Download
M src/opts/Sk4px_NEON.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +30 lines, -0 lines 0 comments Download
M src/opts/Sk4px_SSE2.h View 1 2 3 4 5 6 7 8 9 1 chunk +39 lines, -0 lines 0 comments Download
M src/opts/Sk4px_none.h View 1 2 3 4 5 6 7 8 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138333003/1
5 years, 7 months ago (2015-05-13 13:58:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 14:05:22 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138333003/160001
5 years, 7 months ago (2015-05-13 18:17:18 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138333003/190001
5 years, 7 months ago (2015-05-13 18:40:51 UTC) #8
mtklein_C
5 years, 7 months ago (2015-05-13 18:49:51 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 19:00:16 UTC) #12
reed1
lgtm
5 years, 7 months ago (2015-05-13 19:03:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138333003/190001
5 years, 7 months ago (2015-05-13 19:19:27 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:19:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/8a90edc2a58a4f8a4b4da73eb08e943be09538c0

Powered by Google App Engine
This is Rietveld 408576698