Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1138313003: Fix a race in MultiThreadedProxyResolverTest.ThreeThreads_Basic. (Closed)

Created:
5 years, 7 months ago by Sam McNally
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@multi-threaded-proxy-resolver-flake
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a race in MultiThreadedProxyResolverTest.ThreeThreads_Basic. Committed: https://crrev.com/af7a991ad936da353f973f954b9d27d91717a303 Cr-Commit-Position: refs/heads/master@{#329968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam McNally
5 years, 7 months ago (2015-05-13 02:42:26 UTC) #2
benwells
+cc myself (memory sheriff) and oshima (next memory sheriff). oshima: this fixes the redness on ...
5 years, 7 months ago (2015-05-14 01:06:15 UTC) #4
oshima
On 2015/05/14 01:06:15, benwells wrote: > +cc myself (memory sheriff) and oshima (next memory sheriff). ...
5 years, 7 months ago (2015-05-14 19:14:44 UTC) #6
eroman
lgtm
5 years, 7 months ago (2015-05-14 22:39:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138313003/1
5 years, 7 months ago (2015-05-14 22:40:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 23:11:23 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 23:12:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af7a991ad936da353f973f954b9d27d91717a303
Cr-Commit-Position: refs/heads/master@{#329968}

Powered by Google App Engine
This is Rietveld 408576698