Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1138293002: core_services: Add mojo:surfaces_service to core_services. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core_services: Add mojo:surfaces_service to core_services. In addition to the normal separation of MojoMain() into its own build target, this patch also renames a class and moves a class into the surfaces:: namespace. This was done because they were non-unique symbol names in the resultant binary. (There were two classes named mojo::ContextProviderMojo and had different implementations.) BUG=477435 Committed: https://crrev.com/9b3bd4f87a34c3fb33a63ee123d580485fbe067a Cr-Commit-Position: refs/heads/master@{#329444}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -197 lines) Patch
M components/surfaces/BUILD.gn View 2 chunks +14 lines, -4 lines 0 comments Download
D components/surfaces/context_provider_mojo.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/surfaces/context_provider_mojo.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M components/surfaces/display_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/surfaces/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/surfaces/surfaces_context_provider.h View 3 chunks +13 lines, -12 lines 0 comments Download
A + components/surfaces/surfaces_context_provider.cc View 1 chunk +20 lines, -19 lines 0 comments Download
M components/surfaces/surfaces_output_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/surfaces/surfaces_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/surfaces/surfaces_service_application.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 chunk +2 lines, -0 lines 2 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Elliot Glaysher
This is the last of the services which can be moved without taking on the ...
5 years, 7 months ago (2015-05-12 17:51:52 UTC) #2
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1138293002/diff/1/mandoline/app/core_services_initialization.cc File mandoline/app/core_services_initialization.cc (right): https://codereview.chromium.org/1138293002/diff/1/mandoline/app/core_services_initialization.cc#newcode22 mandoline/app/core_services_initialization.cc:22: GURL("mojo:surfaces_service"), GURL("mojo:core_services"), "Surfaces"); y u no use same ...
5 years, 7 months ago (2015-05-12 17:59:25 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/1138293002/diff/1/mandoline/app/core_services_initialization.cc File mandoline/app/core_services_initialization.cc (right): https://codereview.chromium.org/1138293002/diff/1/mandoline/app/core_services_initialization.cc#newcode22 mandoline/app/core_services_initialization.cc:22: GURL("mojo:surfaces_service"), GURL("mojo:core_services"), "Surfaces"); On 2015/05/12 17:59:25, Ben Goodger (Google) ...
5 years, 7 months ago (2015-05-12 18:00:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138293002/1
5 years, 7 months ago (2015-05-12 18:01:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 18:13:19 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 18:13:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b3bd4f87a34c3fb33a63ee123d580485fbe067a
Cr-Commit-Position: refs/heads/master@{#329444}

Powered by Google App Engine
This is Rietveld 408576698