Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: media/base/time_source.h

Issue 1138283002: Improve comment around strictly increasing wall clock times. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@comment_update
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/time_source.h
diff --git a/media/base/time_source.h b/media/base/time_source.h
index d0607686dbaab4e294530b954a6901fe28b41d03..08cf0f030bd01d6b778c88d001ec69e4335a95ff 100644
--- a/media/base/time_source.h
+++ b/media/base/time_source.h
@@ -51,9 +51,12 @@ class MEDIA_EXPORT TimeSource {
// Converts a vector of media timestamps into a vector of wall clock times. If
// the media time is stopped, returns false and does not modify the output
- // vector. Returns true and converts all timestamps otherwise. Guarantees that
- // wall clock time does not go backwards for monotonically increasing media
- // timestamps.
+ // vector. Returns true and converts all timestamps otherwise.
+ //
+ // Within a single call to GetWallClockTimes() the returned wall clock times
+ // are a strictly increasing function of the given media times. There is no
+ // such guarantee between calls though; e.g., playback rate or audio delay may
+ // change on other threads within the pipeline.
//
// Each timestamp converted from |media_timestamps| will be pushed into
// |wall_clock_times| such that after all timestamps are converted, the two
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698