src/animator/SkAnimatorScript2.cpp - Issue 1138263002: Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/animator/SkAnimatorScript2.cpp

Issue 1138263002: Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/animator/SkAnimatorScript2.cpp

diff --git a/src/animator/SkAnimatorScript2.cpp b/src/animator/SkAnimatorScript2.cpp

index 28912fb6d005ce8ef33320f261a25a6460faa465..80ae0c6aa84c49871d77706719a9dba4494f4e1a 100644

--- a/src/animator/SkAnimatorScript2.cpp

+++ b/src/animator/SkAnimatorScript2.cpp

@@ -412,7 +412,7 @@

if (info->fType != SkType_MemberProperty && info->fType != SkType_MemberFunction)

value->fS32 = *(int32_t*) info->memberData(displayable); // OK for SkScalar too

if (type == SkType_MSec) {

- value->fScalar = value->fS32 * 0.001f;

+ value->fScalar = SkScalarDiv((SkScalar) value->fS32, 1000); // dividing two ints is the same as dividing two scalars

type = SkType_Float;

}

break;

« no previous file with comments | « src/animator/SkAnimatorScript.cpp ('k') | src/animator/SkDisplayPost.cpp » ('j') | no next file with comments »