Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138253003: Notificaiton Message for Unified mode (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notificaiton Message for Unified mode BUG=486187 TEST=covered by test Committed: https://crrev.com/32bef8c15d2a2055cf7cee0b186c3350a97d7c91 Cr-Commit-Position: refs/heads/master@{#329782}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -25 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 1 2 18 chunks +55 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
oshima
5 years, 7 months ago (2015-05-13 17:22:24 UTC) #3
Jun Mukai
https://codereview.chromium.org/1138253003/diff/20001/ash/system/chromeos/tray_display_unittest.cc File ash/system/chromeos/tray_display_unittest.cc (right): https://codereview.chromium.org/1138253003/diff/20001/ash/system/chromeos/tray_display_unittest.cc#newcode305 ash/system/chromeos/tray_display_unittest.cc:305: UpdateTray(); Resetting the variable explicitly from a test case ...
5 years, 7 months ago (2015-05-13 18:03:50 UTC) #4
oshima
Updated as discussed offline. PTAL.
5 years, 7 months ago (2015-05-13 23:56:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138253003/40001
5 years, 7 months ago (2015-05-14 00:37:01 UTC) #7
Jun Mukai
lgtm with a nit. https://codereview.chromium.org/1138253003/diff/40001/ash/system/chromeos/tray_display_unittest.cc File ash/system/chromeos/tray_display_unittest.cc (right): https://codereview.chromium.org/1138253003/diff/40001/ash/system/chromeos/tray_display_unittest.cc#newcode115 ash/system/chromeos/tray_display_unittest.cc:115: GetTray(); CheckUpdate() instead of GetTray()?
5 years, 7 months ago (2015-05-14 00:51:35 UTC) #8
oshima
https://codereview.chromium.org/1138253003/diff/40001/ash/system/chromeos/tray_display_unittest.cc File ash/system/chromeos/tray_display_unittest.cc (right): https://codereview.chromium.org/1138253003/diff/40001/ash/system/chromeos/tray_display_unittest.cc#newcode115 ash/system/chromeos/tray_display_unittest.cc:115: GetTray(); On 2015/05/14 00:51:35, Jun Mukai wrote: > CheckUpdate() ...
5 years, 7 months ago (2015-05-14 01:29:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138253003/60001
5 years, 7 months ago (2015-05-14 01:32:59 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-14 02:04:15 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 02:05:01 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/32bef8c15d2a2055cf7cee0b186c3350a97d7c91
Cr-Commit-Position: refs/heads/master@{#329782}

Powered by Google App Engine
This is Rietveld 408576698