Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/perf/benchmarks/power.py

Issue 1138243003: Telemetry: Exclude techcrunch.com from power.top_25 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cpu
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/power.py
diff --git a/tools/perf/benchmarks/power.py b/tools/perf/benchmarks/power.py
index 5ece11a400334448b85f23191a12fc4a06260261..4a1aeaf3a31ed9f51a79e76ed43f7f2f889a8a4b 100644
--- a/tools/perf/benchmarks/power.py
+++ b/tools/perf/benchmarks/power.py
@@ -52,7 +52,7 @@ class PowerTop10(benchmark.Benchmark):
return 'power.top_10'
-@benchmark.Disabled() # crbug.com/489214
+@benchmark.Enabled('mac')
class PowerTop25(benchmark.Benchmark):
"""Top 25 quiescent power test."""
test = power.QuiescentPower
@@ -60,3 +60,12 @@ class PowerTop25(benchmark.Benchmark):
@classmethod
def Name(cls):
return 'power.top_25'
+
+ def CreateUserStorySet(self, _):
+ # Exclude techcrunch.com. It is not suitable for this benchmark because it
+ # does not consistently become quiescent within 60 seconds.
+ user_stories = self.page_set()
+ found = next((x for x in user_stories if 'techcrunch.com' in x.url), None)
+ if found:
+ user_stories.RemoveUserStory(found)
+ return user_stories
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698