Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138243002: [strong] Introduce strong bit (Closed)

Created:
5 years, 7 months ago by rossberg
Modified:
5 years, 7 months ago
CC:
v8-dev, conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Introduce strong bit Only set on strong functions so far to test basic operation. R=dslomov@chromium.org BUG=v8:3956 LOG=N Committed: https://crrev.com/9be59492f99f3e9d943a3f05b62ab6a4a2617fab Cr-Commit-Position: refs/heads/master@{#28396}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -1 line 1 comment Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A + test/mjsunit/strong/objects.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
rossberg
5 years, 7 months ago (2015-05-12 14:36:00 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-05-12 14:38:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138243002/1
5 years, 7 months ago (2015-05-12 14:40:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138243002/1
5 years, 7 months ago (2015-05-12 14:51:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2634)
5 years, 7 months ago (2015-05-12 14:57:41 UTC) #9
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1138243002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/1138243002/diff/1/src/objects.h#newcode5903 src/objects.h:5903: class IsStrong : public BitField<bool, 26, 1> {}; ...
5 years, 7 months ago (2015-05-12 15:00:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138243002/1
5 years, 7 months ago (2015-05-13 12:57:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 13:31:24 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 13:31:35 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9be59492f99f3e9d943a3f05b62ab6a4a2617fab
Cr-Commit-Position: refs/heads/master@{#28396}

Powered by Google App Engine
This is Rietveld 408576698