Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1138223003: Add check in GrGpu createTexture to make sure we don't create multisampled textures. (Closed)

Created:
5 years, 7 months ago by egdaniel
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add check in GrGpu createTexture to make sure we don't create multisampled textures. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8c9b6f1d71faeff9ae742425466a4ee58492d6d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/gpu/GrGpu.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
So what are your thoughts on this change? Our current behavior (I think) would be ...
5 years, 7 months ago (2015-05-12 17:47:07 UTC) #2
bsalomon
On 2015/05/12 17:47:07, egdaniel wrote: > So what are your thoughts on this change? Our ...
5 years, 7 months ago (2015-05-12 18:46:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138223003/1
5 years, 7 months ago (2015-05-12 20:31:02 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 20:36:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8c9b6f1d71faeff9ae742425466a4ee58492d6d2

Powered by Google App Engine
This is Rietveld 408576698