Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1138193002: Changed the app list string matching formula. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
5 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed the app list string matching formula. This is used to rank apps and webstore results. This should not (really) affect the relative ranking of any results, only the absolute scores that they are assigned internally. However, this will be relevant in the future when we start comparing scores of different types of results against each other. The algorithm (used to score app and webstore results) now has a different tapering formula, designed to reach a higher score with fewer keystrokes. Previously, it was based on the percentage of the full title you had typed (which unfairly de-prioritized apps with long titles, such as "Google Keep - notes and lists"). Now, it has an exponential curve, so you get a reasonably high score with just a few letters matched, and then it tapers off, approaching 1.0 as you type more letters. BUG=422610 Committed: https://crrev.com/4eb24b29619de77aa235ed772135afa391a23797 Cr-Commit-Position: refs/heads/master@{#329574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M ui/app_list/search/tokenized_string_match.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M ui/app_list/search/tokenized_string_match_unittest.cc View 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
Split off from https://codereview.chromium.org/1113483002/. This should not affect the results directly (since they are still ...
5 years, 7 months ago (2015-05-12 08:39:47 UTC) #2
calamity
lgtm
5 years, 7 months ago (2015-05-13 01:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138193002/1
5 years, 7 months ago (2015-05-13 02:07:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 02:56:56 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 02:57:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eb24b29619de77aa235ed772135afa391a23797
Cr-Commit-Position: refs/heads/master@{#329574}

Powered by Google App Engine
This is Rietveld 408576698