Use native radiobutton for Default Search Engine picker dialog.

Use native radiobutton for Default Search Engine picker dialog.

The AppCompat RadioButton has a bug that is being fixed.

BUG=474695
Committed: https://crrev.com/8fad95a4db3afdcaf7495125da4e799a2dba36cd
Cr-Commit-Position: refs/heads/master@{#329617}

[Finnur, 2015-05-12 10:17:33]

finnur@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-05-12 18:14:15]

lgtm after comments

https://codereview.chromium.org/1138183003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/1138183003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:174:
android.widget.RadioButton radioButton =
there's no need to write "android.widget.RadioButton" instead of just importing
android.widget.RadioButton like you were don't before. It's OK this way, but a
bit odd.

https://codereview.chromium.org/1138183003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:177:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
I'd move this if statement above "boolean selected = ..." and make it clear that
this should also be removed once the app compat bug is fixed.

[Finnur, 2015-05-13 10:58:41]

Done.

[Finnur, 2015-05-13 10:58:46]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2015-05-13 10:58:46]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1138183003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-05-13 10:59:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138183003/20001

[Finnur, 2015-05-13 11:17:29]

The CQ bit was unchecked by finnur@chromium.org

[Finnur, 2015-05-13 11:45:51]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2015-05-13 11:46:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138183003/20001

[commit-bot: I haz the power, 2015-05-13 11:49:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-13 11:50:27]

Patchset 2 (id:??) landed as
https://crrev.com/8fad95a4db3afdcaf7495125da4e799a2dba36cd
Cr-Commit-Position: refs/heads/master@{#329617}