Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1138173002: Reland "Use function wrapper argument to expose internal arrays to native scripts." (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Use function wrapper argument to expose internal arrays to native scripts." Committed: https://crrev.com/46f992ddd08c27e5d9898f83534bee67165a7bd3 Cr-Commit-Position: refs/heads/master@{#28367}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -133 lines) Patch
M src/array.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 12 chunks +113 lines, -100 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/date.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/harmony-array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-spread.js View 1 chunk +7 lines, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/math.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/messages.js View 2 chunks +7 lines, -2 lines 0 comments Download
M src/object-observe.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/promise.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/regexp.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/string.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/templates.js View 1 chunk +11 lines, -3 lines 0 comments Download
M src/uri.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part1.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part2.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part3.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part4.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part5.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part6.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part7.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part8.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/global-deleted-property-keyed.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-1878.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/samevalue.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
Please take a look at the second patch set. The original CL has been reverted ...
5 years, 7 months ago (2015-05-12 07:39:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138173002/20001
5 years, 7 months ago (2015-05-12 07:54:11 UTC) #4
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/1138173002/diff/20001/test/mjsunit/global-deleted-property-keyed.js File test/mjsunit/global-deleted-property-keyed.js (right): https://codereview.chromium.org/1138173002/diff/20001/test/mjsunit/global-deleted-property-keyed.js#newcode31 test/mjsunit/global-deleted-property-keyed.js:31: // Regression test that exposed the_hole ...
5 years, 7 months ago (2015-05-12 08:05:04 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 08:37:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138173002/40001
5 years, 7 months ago (2015-05-12 13:08:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 14:00:54 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 14:01:09 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/46f992ddd08c27e5d9898f83534bee67165a7bd3
Cr-Commit-Position: refs/heads/master@{#28367}

Powered by Google App Engine
This is Rietveld 408576698