Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: src/parser.cc

Issue 1138153003: Use ExpressionClassifier to identify valid arrow function formals (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Classify destructuring bindings as invalid unless destructuring is enabled Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/preparser.h » ('j') | src/preparser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index 26771e4e347830c81c13377cbd24c7d1d5897213..6422a94c02882da5e7d8ba816f5bc454937deb57 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -1150,10 +1150,8 @@ FunctionLiteral* Parser::ParseLazy(Isolate* isolate, ParseInfo* info,
}
if (ok) {
- ExpressionClassifier classifier;
- Expression* expression = ParseArrowFunctionLiteral(
- scope, error_locs, has_rest, &classifier, &ok);
- ValidateExpression(&classifier, &ok);
+ Expression* expression =
+ ParseArrowFunctionLiteral(scope, error_locs, has_rest, &ok);
if (ok) {
// Scanning must end at the same position that was recorded
// previously. If not, parsing has been interrupted due to a stack
« no previous file with comments | « no previous file | src/preparser.h » ('j') | src/preparser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698