Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138153002: Introduce chrome://cr-elements with Polymer .8 cr-elements (Closed)

Created:
5 years, 7 months ago by stevenjb
Modified:
5 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce chrome://cr-elements with Polymer .8 cr-elements This CL should facilitate conversion of cr- elements and help debugging them in isolation. BUG=485381

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -0 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/cr_elements_ui/cr_elements_ui.html View 1 chunk +61 lines, -0 lines 3 comments Download
A chrome/browser/resources/cr_elements_ui/cr_elements_ui.js View 1 chunk +44 lines, -0 lines 2 comments Download
M chrome/browser/ui/webui/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +21 lines, -0 lines 1 comment Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
stevenjb
I started working on converting cr-expand-button and wanted a familiar/easy way to test the new ...
5 years, 7 months ago (2015-05-12 06:41:55 UTC) #2
Jeremy Klein
Is this just a demo page for the cr-elements. I don't really think we should ...
5 years, 7 months ago (2015-05-12 06:51:13 UTC) #3
michaelpg
5 years, 7 months ago (2015-05-14 03:05:11 UTC) #4 
I don't mind having this. I think it's one less step for newcomers especially
(as opposed to trying to run a server to test inter-dependent elements locally).

https://codereview.chromium.org/1138153002/diff/1/chrome/browser/resources/cr...
File chrome/browser/resources/cr_elements_ui/cr_elements_ui.js (right):

https://codereview.chromium.org/1138153002/diff/1/chrome/browser/resources/cr...
chrome/browser/resources/cr_elements_ui/cr_elements_ui.js:42: 
nit: kill blank line

https://codereview.chromium.org/1138153002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

https://codereview.chromium.org/1138153002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:216: class
CrElementsUI : public content::WebUIController {
This is weird. I'd prefer you create a new file.

Powered by Google App Engine
This is Rietveld 408576698