chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h - Issue 1138143002: Pass Device ID in the oauth2/token request. Keep Device ID in local state on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h

Issue 1138143002: Pass Device ID in the oauth2/token request. Keep Device ID in local state on Chrome OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/session/user_session_manager.cc ('K') | « chrome/browser/chromeos/login/session/user_session_manager.cc ('k') | chrome/browser/chromeos/login/signin/oauth2_token_fetcher.cc » ('j') | chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h

diff --git a/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h b/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h

index 5dd2e6d7f5eb6ece0859b0f6ef157e69dd0b7428..3cea28b8fd5be44309978da8971eb4b0bd510475 100644

--- a/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h

+++ b/chrome/browser/chromeos/login/signin/oauth2_token_fetcher.h

@@ -40,7 +40,8 @@ class OAuth2TokenFetcher : public base::SupportsWeakPtr<OAuth2TokenFetcher>,

void StartExchangeFromCookies(const std::string& session_index,

const std::string& signin_scoped_device_id);

- void StartExchangeFromAuthCode(const std::string& auth_code);

+ void StartExchangeFromAuthCode(const std::string& auth_code,

+ const std::string& signin_scoped_device_id);

private:

// Decides how to proceed on GAIA |error|. If the error looks temporary,