chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc - Issue 1138143002: Pass Device ID in the oauth2/token request. Keep Device ID in local state on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc

Issue 1138143002: Pass Device ID in the oauth2/token request. Keep Device ID in local state on Chrome OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final version. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/session/user_session_manager.cc ('K') | « chrome/browser/chromeos/login/signin/oauth2_token_fetcher.cc ('k') | chrome/browser/resources/chromeos/login/screen_gaia_signin.js » ('j') | chrome/browser/signin/chrome_signin_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc

diff --git a/chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc b/chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc

index c0bcbc98e1f80706ab1c7d2e6309bb12681dca38..953c5d584357f1fe77ee37c179d6f0374ebc8bc9 100644

--- a/chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc

+++ b/chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc

@@ -21,7 +21,10 @@ void OAuth2TokenInitializer::Start(const UserContext& user_context,

user_context_ = user_context;

oauth2_token_fetcher_.reset(new OAuth2TokenFetcher(

this, g_browser_process->system_request_context()));

- oauth2_token_fetcher_->StartExchangeFromAuthCode(user_context.GetAuthCode());

+ if (user_context.GetDeviceId().empty())

+ NOTREACHED() << "Device ID is not set";

achuithb 2015/05/12 23:25:01 I assume you're doing this in preference to a DCHE

dzhioev (left Google) 2015/05/13 00:25:18 Yes, on Chrome OS NOTREACHED writes logs in releas

+ oauth2_token_fetcher_->StartExchangeFromAuthCode(user_context.GetAuthCode(),

+ user_context.GetDeviceId());

}

void OAuth2TokenInitializer::OnOAuth2TokensAvailable(