Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 1138143002: Pass Device ID in the oauth2/token request. Keep Device ID in local state on Chrome OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js
diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
index 8a8ba601c339f4d49b1955bd83af44add4082930..fc5836e71b453201ba435edbb9eaab29ea349c28 100644
--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
@@ -33,7 +33,6 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
'onFrameError',
'updateCancelButtonState',
'showWhitelistCheckFailedError',
- 'updateDeviceId',
],
/**
@@ -153,8 +152,6 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
'backButton', this.onBackButton_.bind(this));
this.gaiaAuthHost_.addEventListener(
'showView', this.onShowView_.bind(this));
- this.gaiaAuthHost_.addEventListener('attemptLogin',
- this.onAttemptLogin_.bind(this));
this.gaiaAuthHost_.confirmPasswordCallback =
this.onAuthConfirmPassword_.bind(this);
this.gaiaAuthHost_.noPasswordCallback =
@@ -630,16 +627,6 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
},
/**
- * Invoked when the auth host emits 'attemptLogin' event.
- * @param {Object} Message object with |detail| field keeping email:
- * like {detail: 'user@gmail.com'} .
- * @private
- */
- onAttemptLogin_: function(e) {
- chrome.send('attemptLogin', [e.detail]);
- },
-
- /**
* Invoked when the user has successfully authenticated via SAML, the
* principals API was not used and the auth host needs the user to confirm
* the scraped password.
@@ -747,8 +734,7 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
credentials.email,
credentials.password,
credentials.authCode,
- credentials.usingSAML,
- credentials.deviceId
+ credentials.usingSAML
]);
}
} else {
@@ -953,18 +939,6 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
if (!show)
Oobe.showSigninUI();
- },
-
- /**
- * Inform Gaia of new deviceId.
- * @param {data} Object like {'deviceId': 'test-device-id'}
- */
- updateDeviceId: function(data) {
- if (!this.isNewGaiaFlow)
- return;
-
- if (data && data.deviceId)
- this.gaiaAuthHost_.updateDeviceId(data.deviceId);
- },
+ }
};
});

Powered by Google App Engine
This is Rietveld 408576698