Issue 113813003: Cleanup the policy code after the recent moves into the component.

Issue 113813003: Cleanup the policy code after the recent moves into the component. (Closed)

Created:
7 years ago by Joao da Silva

Modified:
7 years ago

Reviewers:
dconnelly

CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup the policy code after the recent moves into the component. - policy_transformations.cc is not needed anymore, since PolicyServiceImpl can now refer to the generated policies by name. - moved generate_policy_source_unittest.cc into the component. - removed stale .gitignore entries. BUG=271392 TBR=joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240940

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -388 lines)			Patch
M	.gitignore	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/net/proxy_policy_handler_unittest.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/policy/browser_policy_connector.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store_test.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
D	chrome/browser/policy/generate_policy_source_unittest.cc	View		1 chunk	+0 lines, -123 lines	0 comments	Download
D	chrome/browser/policy/policy_transformations.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/browser/policy/policy_transformations.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
D	chrome/browser/policy/policy_transformations_unittest.cc	View		1 chunk	+0 lines, -76 lines	0 comments	Download
M	chrome/browser/policy/profile_policy_connector.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/prefs/proxy_policy_unittest.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/base/testing_profile.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	components/components_tests.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	components/policy/core/common/generate_policy_source_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	components/policy/core/common/policy_pref_names.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	components/policy/core/common/policy_service_impl.h	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	components/policy/core/common/policy_service_impl.cc	View		2 chunks	+57 lines, -7 lines	0 comments	Download
M	components/policy/core/common/policy_service_impl_unittest.cc	View		6 chunks	+47 lines, -48 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/113813003/20001

7 years ago (2013-12-16 13:54:45 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=203026

7 years ago (2013-12-16 14:58:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/113813003/20001

7 years ago (2013-12-16 15:44:34 UTC) #5

Message was sent while issue was closed.

Change committed as 240940

Expand Messages | Collapse Messages