Delay creating easy signin TPM keys until TPM is initialized

Delay creating easy signin TPM keys until TPM is initialized

EasyUnlockTpmKeyManager should not start poking TPM on worker thread
before TPM initialization is finished on IO thread in order to
prevent IO thread being blocked during startup waiting for easy
signin key pair being created.

BUG=464524
TEST=Easy signin works after initializing easy unlock and signin in
once.

Committed: https://crrev.com/fbb6296bee4b2c8fe50ddc2df53ca580560815f6
Cr-Commit-Position: refs/heads/master@{#329475}

[tbarzic, 2015-05-12 02:17:37]

tbarzic@chromium.org changed reviewers:
+ pneubeck@chromium.org, xiyuan@chromium.org

[xiyuan, 2015-05-12 04:57:22]

LGTM. Please wait for pneubeck@ as well.

[pneubeck (no reviews), 2015-05-12 12:21:44]

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
(right):

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc:59:
void RunCallbackWithoutSlotOnThreadRunner(
s/ThreadRunner/TaskRunner/

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h
(right):

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h:33: //  
  Empty for signing service.
signing or sign-in as in the line before?

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h:103: //
|this| may proceed with creating user-specific TPM key for easy sign-in.
s/creating/creating a/

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
File
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
(right):

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc:453:
FinalizeTestNssUser();
why not the EXPECT_FALSE into the FinalizeTestNssUser and calling it
CheckKeyGenerationAndFinalizeTestNssUser or similar?

at least that would move all the distributed assertions to a single place and
allow you to add a comment describing the rational behind that.

[tbarzic, 2015-05-12 17:10:47]

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
(right):

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc:59:
void RunCallbackWithoutSlotOnThreadRunner(
On 2015/05/12 12:21:43, pneubeck wrote:
> s/ThreadRunner/TaskRunner/

Done.

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h
(right):

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h:33: //  
  Empty for signing service.
On 2015/05/12 12:21:43, pneubeck wrote:
> signing or sign-in as in the line before?

Done.

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h:103: //
|this| may proceed with creating user-specific TPM key for easy sign-in.
On 2015/05/12 12:21:43, pneubeck wrote:
> s/creating/creating a/

Done.

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
File
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
(right):

https://codereview.chromium.org/1138123003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc:453:
FinalizeTestNssUser();
On 2015/05/12 12:21:44, pneubeck wrote:
> why not the EXPECT_FALSE into the FinalizeTestNssUser and calling it
> CheckKeyGenerationAndFinalizeTestNssUser or similar?
> 
> at least that would move all the distributed assertions to a single place and
> allow you to add a comment describing the rational behind that.

Done.

[pneubeck (no reviews), 2015-05-12 17:30:27]

lgtm

[tbarzic, 2015-05-12 18:03:51]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2015-05-12 18:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1138123003/#ps20001
(title: "pneubeck comments")

[commit-bot: I haz the power, 2015-05-12 18:04:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138123003/20001

[tbarzic, 2015-05-12 18:07:54]

The CQ bit was unchecked by tbarzic@chromium.org

[tbarzic, 2015-05-12 20:30:10]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2015-05-12 20:30:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138123003/20001

[commit-bot: I haz the power, 2015-05-12 20:35:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 20:36:33]

Patchset 2 (id:??) landed as
https://crrev.com/fbb6296bee4b2c8fe50ddc2df53ca580560815f6
Cr-Commit-Position: refs/heads/master@{#329475}