Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1138113006: Wrap calls to dup() in shared_memory_posix.cc in HANDLE_EINTR. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Robert Sesek, Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wrap calls to dup() in shared_memory_posix.cc in HANDLE_EINTR. There's no reason that an interrupt to a dup() should cause a SharedMemory operation to fail. BUG= Committed: https://crrev.com/fdbad9e261cffbd6cee672c5a8edbc5e58725531 Cr-Commit-Position: refs/heads/master@{#330584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/memory/shared_memory_posix.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
rsesek: Please review. Note that this CL was not prompted by an observed failures. I ...
5 years, 7 months ago (2015-05-19 18:06:22 UTC) #2
Robert Sesek
LGTM. I wouldn't expect dup() to report EINTR (it's not really blocking), but good catch.
5 years, 7 months ago (2015-05-19 18:09:31 UTC) #3
erikchen
thestig: Looking for an OWNER review.
5 years, 7 months ago (2015-05-19 18:12:49 UTC) #5
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-19 18:17:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138113006/1
5 years, 7 months ago (2015-05-19 18:24:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 19:35:46 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 19:37:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdbad9e261cffbd6cee672c5a8edbc5e58725531
Cr-Commit-Position: refs/heads/master@{#330584}

Powered by Google App Engine
This is Rietveld 408576698