Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1138113003: Remove Test Accounts service client (Closed)

Created:
5 years, 7 months ago by pval...(no longer on Chromium)
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Test Accounts service client This service was used as part of a previous Sync end-to-end testing effort and is no longer used. BUG=NONE Committed: https://crrev.com/9fdec26ebe2e43f060d261cf2bdf8df935410ec5 Cr-Commit-Position: refs/heads/master@{#330144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -482 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sync/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
D sync/test/accounts_client/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D sync/test/accounts_client/test_accounts_client.h View 1 chunk +0 lines, -63 lines 0 comments Download
D sync/test/accounts_client/test_accounts_client.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D sync/test/accounts_client/test_accounts_client_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D sync/test/accounts_client/url_request_context_getter.h View 1 chunk +0 lines, -43 lines 0 comments Download
D sync/test/accounts_client/url_request_context_getter.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pval...(no longer on Chromium)
dpranke@ for top-level build files maniscalco@ for sync code
5 years, 7 months ago (2015-05-15 01:08:12 UTC) #2
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-15 03:17:02 UTC) #3
maniscalco
lgtm
5 years, 7 months ago (2015-05-15 15:35:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138113003/1
5 years, 7 months ago (2015-05-15 17:29:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 18:38:37 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:39:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fdec26ebe2e43f060d261cf2bdf8df935410ec5
Cr-Commit-Position: refs/heads/master@{#330144}

Powered by Google App Engine
This is Rietveld 408576698