Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1138073005: Revert of Temporarily revert just Multiply to see if that's the source of NEON diffs. (Closed)

Created:
5 years, 7 months ago by mtklein
Modified:
5 years, 7 months ago
Reviewers:
mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Temporarily revert just Multiply to see if that's the source of NEON diffs. (patchset #2 id:20001 of https://codereview.chromium.org/1129293005/) Reason for revert: Undo Xor revert. Getting too confusing now. Original issue's description: > Temporarily revert just Multiply to see if that's the source of NEON diffs. > > Local testing is confusing and inconclusive. Pulling out the big guns. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5b9f352ff1e245dd48e200f8f8b683f4569547d3 > > Committed: https://skia.googlesource.com/skia/+/6095260e55ac5f263df26cdde427531a0e7da8dd TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ec1f77d097fa86f5d126a1676b97eea7cff3fdbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/core/SkXfermode.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Temporarily revert just Multiply to see if that's the source of NEON ...
5 years, 7 months ago (2015-05-14 18:48:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138073005/1
5 years, 7 months ago (2015-05-14 18:48:54 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 18:49:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ec1f77d097fa86f5d126a1676b97eea7cff3fdbf

Powered by Google App Engine
This is Rietveld 408576698