Add invalid url failure to screencapture command

Add invalid url failure to screencapture command

Replaces the DCHECK for validity of the upload url with an explicit runtime
check. If the check fails the client sends a FAILURE_INVALID_URL error to
DMServer and logs a message to the ui log.

BUG=480982
Committed: https://crrev.com/28140ebf081ade920546ebeb82013765b8f1e313
Cr-Commit-Position: refs/heads/master@{#329388}

[cschuet (SLOW), 2015-05-12 08:28:23]

cschuet@chromium.org changed reviewers:
+ pneubeck@chromium.org

[cschuet (SLOW), 2015-05-12 08:28:23]

Hey Philipp, could you take a look at this CL?

[pneubeck (no reviews), 2015-05-12 08:54:12]

lgtm

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
(right):

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc:145:
base::DictionaryValue* payload;
could be initialized to nullptr

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc:218:
num_pending_screenshots_ = root_windows.size();
you're omitting this assignment now in case of (root_windows.size() == 0).

[pneubeck (no reviews), 2015-05-12 08:54:12]

lgtm

lgtm

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
(right):

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc:145:
base::DictionaryValue* payload;
could be initialized to nullptr

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc:218:
num_pending_screenshots_ = root_windows.size();
you're omitting this assignment now in case of (root_windows.size() == 0).

[cschuet (SLOW), 2015-05-12 09:29:59]

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
(right):

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc:145:
base::DictionaryValue* payload;
On 2015/05/12 08:54:12, pneubeck wrote:
> could be initialized to nullptr

Done.

https://codereview.chromium.org/1138063006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc:218:
num_pending_screenshots_ = root_windows.size();
On 2015/05/12 08:54:12, pneubeck wrote:
> you're omitting this assignment now in case of (root_windows.size() == 0).

Acknowledged.

[cschuet (SLOW), 2015-05-12 09:57:47]

The CQ bit was checked by cschuet@chromium.org

[cschuet (SLOW), 2015-05-12 09:57:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
pneubeck@chromium.org
Link to the patchset: https://codereview.chromium.org/1138063006/#ps40001
(title: "uninitialized variable")

[commit-bot: I haz the power, 2015-05-12 09:58:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138063006/40001

[commit-bot: I haz the power, 2015-05-12 10:32:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-12 10:33:26]

Patchset 3 (id:??) landed as
https://crrev.com/28140ebf081ade920546ebeb82013765b8f1e313
Cr-Commit-Position: refs/heads/master@{#329388}