Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1138033002: [Autofill] No longer send form name at query time. (Closed)

Created:
5 years, 7 months ago by Mathieu
Modified:
5 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] No longer send form name at query time. Added as part of a recent CL, the form name is not required for the improvements to the Autofill server that are upcoming. BUG=484229 TEST=FormStructure*,AutofillServer* Committed: https://crrev.com/cc762f484dbbddf43b3cc6c6aa25b1e4233579ae Cr-Commit-Position: refs/heads/master@{#329211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/browser/autofill/autofill_server_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 6 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mathieu
Hi, Have a look, I'm reverting part of my last change as it may not ...
5 years, 7 months ago (2015-05-11 14:49:49 UTC) #2
Evan Stade
lgtm
5 years, 7 months ago (2015-05-11 17:52:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138033002/1
5 years, 7 months ago (2015-05-11 18:00:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 18:52:38 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:53:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc762f484dbbddf43b3cc6c6aa25b1e4233579ae
Cr-Commit-Position: refs/heads/master@{#329211}

Powered by Google App Engine
This is Rietveld 408576698