chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java - Issue 1138013008: [Sync] Make it impossible to get a reference to AndroidSyncSettings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

Issue 1138013008: [Sync] Make it impossible to get a reference to AndroidSyncSettings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address nit. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

index 5e19e2a6df03baab87739ebe5c328e8637ab52ac..1e7cbd8c2e36e11c8085738728a6aecf05fccb0b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java

@@ -104,7 +104,7 @@ public class InvalidationController implements ApplicationStatus.ApplicationStat

@Override

public void onApplicationStateChange(int newState) {

- if (AndroidSyncSettings.get(mContext).isSyncEnabled()) {

+ if (AndroidSyncSettings.isSyncEnabled(mContext)) {

if (newState == ApplicationState.HAS_RUNNING_ACTIVITIES) {

start();

} else if (newState == ApplicationState.HAS_PAUSED_ACTIVITIES) {