Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1138013007: Temporarily add hook for extending net_java_test_support. (Closed)

Created:
5 years, 7 months ago by Yaron
Modified:
5 years, 7 months ago
Reviewers:
asanka
CC:
cbentzel+watch_chromium.org, chromium-reviews, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@window
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily add hook for extending net_java_test_support. Defines a list 'net_test_extra_libs' that is included in net_java_test_support. org.apache.http is deprecated and being removed. This enables temporary inclusion of a replacement jar until the dependency is removed. BUG=488192 Committed: https://crrev.com/05fc830812d2cbed9c438918150f884b6dc91075 Cr-Commit-Position: refs/heads/master@{#330105}

Patch Set 1 #

Patch Set 2 : fix bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M net/net.gyp View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Yaron
5 years, 7 months ago (2015-05-15 00:50:20 UTC) #2
asanka
lgtm
5 years, 7 months ago (2015-05-15 14:44:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138013007/20001
5 years, 7 months ago (2015-05-15 14:51:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138013007/20001
5 years, 7 months ago (2015-05-15 16:00:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 16:31:41 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:32:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05fc830812d2cbed9c438918150f884b6dc91075
Cr-Commit-Position: refs/heads/master@{#330105}

Powered by Google App Engine
This is Rietveld 408576698