Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1138013004: Revert of Revert of Remove workaround to for lower glsl support for qualcomm (Closed)

Created:
5 years, 7 months ago by egdaniel
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1135393003/) Reason for revert: trying once more Original issue's description: > Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1133543004/) > > Reason for revert: > breaks many qualcomm gms > > Original issue's description: > > Remove workaround to for lower glsl support for qualcomm > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/9770bdce776f45367c419b8dd82219eece26ca5c > > TBR=bsalomon@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/0cfe1242ee284290bde1ebe3f48626c555fdac51 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b72f920ef581e9cf50a6c1afc80ed04bb086488e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/gpu/gl/GrGLContext.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
egdaniel
Created Revert of Revert of Remove workaround to for lower glsl support for qualcomm
5 years, 7 months ago (2015-05-13 15:46:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138013004/1
5 years, 7 months ago (2015-05-13 15:46:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b72f920ef581e9cf50a6c1afc80ed04bb086488e
5 years, 7 months ago (2015-05-13 15:46:56 UTC) #3
egdaniel
5 years, 7 months ago (2015-05-13 17:32:34 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1130413006/ by egdaniel@google.com.

The reason for reverting is: still broken :(.

Powered by Google App Engine
This is Rietveld 408576698