Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1138013002: CacheStorage: Remove duplicate member from CacheStorageManagerTest for cleanup (Closed)

Created:
5 years, 7 months ago by nhiroki
Modified:
5 years, 7 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@putall
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CacheStorage: Remove duplicate member from CacheStorageManagerTest for cleanup This is a follow-up patch for merging CacheStorageError and ErrorType: https://codereview.chromium.org/1132683003 BUG=425505 TEST=n/a Committed: https://crrev.com/3a99f5984b6e2010377866f2f4221a4d3f52c374 Cr-Commit-Position: refs/heads/master@{#329398}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 1 11 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
PTAL, thanks!
5 years, 7 months ago (2015-05-12 06:02:33 UTC) #2
jkarlin
lgtm
5 years, 7 months ago (2015-05-12 10:24:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138013002/20001
5 years, 7 months ago (2015-05-12 13:25:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 13:28:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:29:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a99f5984b6e2010377866f2f4221a4d3f52c374
Cr-Commit-Position: refs/heads/master@{#329398}

Powered by Google App Engine
This is Rietveld 408576698