Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1138003007: Add gypi_to_gn for content/utility sources list (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gypi_to_gn for content/utility sources list BUG=None Committed: https://crrev.com/7b6128acec63c2ca021e314aeed1f77c5896f4c0 Cr-Commit-Position: refs/heads/master@{#330393}

Patch Set 1 #

Patch Set 2 : Update libcontent target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_utility.gypi View 1 1 chunk +23 lines, -15 lines 0 comments Download
M content/utility/BUILD.gn View 2 chunks +4 lines, -12 lines 0 comments Download
A + content/utility/utility.gni View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Rockot(use gerrit already)
please take a look
5 years, 7 months ago (2015-05-16 03:36:31 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-18 15:47:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138003007/20001
5 years, 7 months ago (2015-05-18 17:37:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 20:18:11 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b6128acec63c2ca021e314aeed1f77c5896f4c0
Cr-Commit-Position: refs/heads/master@{#330393}

Powered by Google App Engine
This is Rietveld 408576698