Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1138003004: Override user data directory to the temp for ProfileInfoCacheTest. (Closed)

Created:
5 years, 7 months ago by emaxx
Modified:
5 years, 7 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Override user data directory to the temp for ProfileInfoCacheTest. Currently the tests of this suite (or, at least, DownloadHighResAvatarTest) read and write to the default system-wide location, which is not good and can cause tests flakiness. Now we override the DIR_USER_DATA to a temporary directory instead. BUG=486785 Committed: https://crrev.com/a2e114926ad900ec3c34a623fdae85832f163624 Cr-Commit-Position: refs/heads/master@{#329429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/profiles/profile_info_cache_unittest.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
emaxx
Hi Michael, please take a look at this CL with tests fix.
5 years, 7 months ago (2015-05-11 19:00:08 UTC) #2
Mike Lerman
lgtm
5 years, 7 months ago (2015-05-12 17:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138003004/1
5 years, 7 months ago (2015-05-12 17:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 17:19:17 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 17:21:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2e114926ad900ec3c34a623fdae85832f163624
Cr-Commit-Position: refs/heads/master@{#329429}

Powered by Google App Engine
This is Rietveld 408576698