Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1137993007: Crop image at image_loader. (Closed)

Created:
5 years, 7 months ago by yawano
Modified:
5 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crop image at image_loader. To avoid wide image becomes blurry thumbnail, crop image at image_loader. Currently it is used only for thumbnails, we only support to crop an image into square. BUG=480679 TEST=ImageLoaderJsTest.ImageLoaderTest Committed: https://crrev.com/1fc7409719fa3598a2861aaa9bfcd8d3a00be696 Cr-Commit-Position: refs/heads/master@{#329609}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -30 lines) Patch
M chrome/browser/chromeos/file_manager/image_loader_jstest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 2 chunks +22 lines, -12 lines 0 comments Download
M ui/file_manager/image_loader/compiled_resources.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/image_loader/image_loader.js View 1 1 chunk +100 lines, -14 lines 0 comments Download
A ui/file_manager/image_loader/image_loader_unittest.html View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/file_manager/image_loader/image_loader_unittest.js View 1 chunk +165 lines, -0 lines 0 comments Download
M ui/file_manager/image_loader/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/image_loader/request.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
PTAL. Thank you!
5 years, 7 months ago (2015-05-13 04:09:47 UTC) #2
hirono
lgtm! https://codereview.chromium.org/1137993007/diff/1/ui/file_manager/image_loader/image_loader.js File ui/file_manager/image_loader/image_loader.js (right): https://codereview.chromium.org/1137993007/diff/1/ui/file_manager/image_loader/image_loader.js#newcode268 ui/file_manager/image_loader/image_loader.js:268: source.width < source.height ? source.width : source.height; nit: ...
5 years, 7 months ago (2015-05-13 09:02:25 UTC) #3
yawano
Thank you! https://codereview.chromium.org/1137993007/diff/1/ui/file_manager/image_loader/image_loader.js File ui/file_manager/image_loader/image_loader.js (right): https://codereview.chromium.org/1137993007/diff/1/ui/file_manager/image_loader/image_loader.js#newcode268 ui/file_manager/image_loader/image_loader.js:268: source.width < source.height ? source.width : source.height; ...
5 years, 7 months ago (2015-05-13 09:11:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137993007/20001
5 years, 7 months ago (2015-05-13 09:11:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 09:58:10 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 09:59:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fc7409719fa3598a2861aaa9bfcd8d3a00be696
Cr-Commit-Position: refs/heads/master@{#329609}

Powered by Google App Engine
This is Rietveld 408576698